fix: Remove deadzone when hovering example table cells #5363
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
cephalization
changed the title
cephalization
commented
Nov 14, 2024
| @@ -411,6 +413,8 @@ function TableBody<T>({ table }: { table: Table<T> }) { | |||
| <td | |||
| key={cell.id} | |||
| style={{ | |||
| padding: 0, | |||
| height: 1, | |||
There was a problem hiding this comment.
The cell still grows to fit, we just need some height declared so that height: 100% in the children works
There was a problem hiding this comment.
Can you put a comment to that effect?
Parker-Stafford
approved these changes
Nov 14, 2024
|
Still needs a bit of work on the shared components; the styling changes have negative impacts on the experiment page |
cephalization
force-pushed
the
cephalization/remove-example-table-control-hover-deadzone
branch
from
3a8bfb9
to
1bbc674
Compare
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a deadzone on the control hovering styles caused by padding in the parent td element.
Now cell contents control their own padding, and fill available td space, so that the hover target matches the visible cell area.
Before
After
Resolves #5554